This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran, committed] Fix typos in rand.c and normalize.c


Tobias Schlüter wrote:
 > Well, I just tried again, without your fix. No problems in the
> testsuite. We don't have a test for rand(), and apparently the linker on
> i686-linux is not very tightly checking the object files it is passed.
> 

Now I embarassed myself again. I built from the wrong directory, so that
was not a valid test. If building the whole tree it does indeed fail in
the testsuite. I did run the testsuite yesterday, after bulding with my
patch, and there were no failures, and I'm sure that it rebuilt the
library, because I looked at it to see that the warning which originally
prompted the patch had gone. I don't know what I did wrong yesterday,
but I promise that I will be more cautious in the future.

> I'm sorry for the breakage, and will not make such stupid mistakes again
> (wishful thinking).

Looks like I already did :-(

- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]