This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 15825: emit_move_insn problems in ifcvt.c (take 2)


On Fri, Jun 25, 2004 at 08:49:38AM -0600, Roger Sayle wrote:
> As a follow-up patch, I'll propose inlining seq_contains_jump
> directly into end_ifcvt_sequence, it's only remaining caller, to
> minimize any additional overhead with using this approach.
> Pre-approval?

Yes, merge the JUMP_INSN check into the existing insn scan loop.

> 	* ifcvt.c (unshare_ifcvt_sequence): Rename to end_ifcvt_sequence.
> 	Use get_isns and end_sequence instead of accepting a seq argument.
> 	Scan the instruction sequence for unrecognizable or jump insns.
> 	(noce_try_move, noce_try_store_flag, noce_try_store_flag_constants,
> 	noce_try_addcc, noce_try_store_flag_mask, noce_try_cmove,
> 	noce_try_cmove_arith, noce_try_minmax, noce_try_abs,
> 	noce_try_sign_mask): Use end_ifcvt_sequence to factor common code.
> 
> 	* gcc.dg/pr15825-1.c: New test case.

Ok.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]