This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix structs, c-decl rewrite, and PCH
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Andrew Pinski <apinski at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 21 Jun 2004 23:24:18 -0700
- Subject: Re: [PATCH] Fix structs, c-decl rewrite, and PCH
- References: <9C261EA2-C40A-11D8-B923-00039351ED8A@apple.com>
Andrew Pinski <apinski@apple.com> writes:
> The problem I am seeing is that after the PCH is read in some
> structs which you declare in not in the PCH file but in the
> source file is not being finished. This is caused by there
> being an extra scope being pushed for the file but there is
> an already a scope for the file. This patch fixes this
> problem by checking if there exist a file scope already exist
> in push_file_scope and return right way.
>
> OK? Bootstrapped on powerpc-apple-darwin with no regressions?
Patch is OK provided that you properly format the test case for
gcc.dg/pch and check it in too. (Perhaps you intended to do this but
I can't tell for sure.)
zw