This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: sparc_gimplify_va_arg

On Fri, 11 Jun 2004 08:55:46 +0200, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:

>> 2004-06-11  Jason Merrill  <jason@redhat.com>
>>
>> 	* config/sparc/sparc.c (sparc_gimplify_va_arg): New fn.
>> 	(TARGET_GIMPLIFY_VA_ARG_EXPR): Define.
>
> Thanks for doing this.  However, I see you duplicated sparc_va_arg pretty 
> much entirely.  Would it not be better to factor out the common structure 
> between both functions?  Or is sparc_va_arg already doomed to death?

The latter.  Once all targets have the gimplifier hook, the expanders will
go away.

Hmm, actually, maybe they can go away individually as targets are
converted...

Jason
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]