This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: Unreviewed Patches for H8/300 : Request for review
- From: "Anil Paranjape" <AnilP1 at KPITCummins dot com>
- To: <law at redhat dot com>,<mmitchell at codesourcery dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 9 Jun 2004 16:29:33 +0530
- Subject: RE: Unreviewed Patches for H8/300 : Request for review
Hi Jeff,
Please find following patch for ldm_h8300s_4 expander as per your suggestion.
I tested H8 port after build. Comparing with other "ldm_h8300s_X" expanders, it was obvious.
ChangeLog
2004-06-09 Anil Paranjpe <anilp1@kpitcummins.com>
* h8300/h8300.md (ldm_h8300s_4): Fixed condition for expander.
Patch text:
************************************************************************************
*** gcc-3.5/gcc/config/h8300/h8300.md.old Wed Jun 9 09:55:35 2004
--- gcc-3.5/gcc/config/h8300/h8300.md Wed Jun 9 09:56:49 2004
***************
*** 2107,2113 ****
(match_operand:SI 1 "register_operand" "")
(match_operand:SI 2 "register_operand" "")
(match_operand:SI 3 "register_operand" "")]
! "TARGET_H8300S && !TARGET_NORMAL_MODE
&& h8300_regs_ok_for_stm (4, operands)"
"
{
--- 2107,2113 ----
(match_operand:SI 1 "register_operand" "")
(match_operand:SI 2 "register_operand" "")
(match_operand:SI 3 "register_operand" "")]
! "TARGET_H8300S
&& h8300_regs_ok_for_stm (4, operands)"
"
{
************************************************************************************
Regards,
Anil Paranjpe
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas' SH and H8 Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools are released on June 1, 2004.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----Original Message-----
From: Jeffrey A Law [mailto:law@redhat.com]
Sent: Tuesday, June 08, 2004 10:12 PM
To: Anil Paranjape; mmitchell@codesourcery.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Unreviewed Patches for H8/300 : Request for review
On Tue, 2004-06-08 at 02:52, Anil Paranjape wrote:
> Hi,
>
> Please find following links of two patches,
>
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00216.html
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00215.html
>
> Kindly review above two patches for H8/300 target.
These are both fine. I'll install them into the mainline
momentarily.
Mark -- these should both be safe for the GCC 3.4 branch. I'll
include the changes as a single patch below to make it easy for you
to apply to the GCC 3.4 branch.
Anil -- from my investigation it appears that the condition for
the ldm_h8300s_4 expander is wrong:
(define_expand "ldm_h8300s_4"
[(match_operand:SI 0 "register_operand" "")
(match_operand:SI 1 "register_operand" "")
(match_operand:SI 2 "register_operand" "")
(match_operand:SI 3 "register_operand" "")]
"TARGET_H8300S && !TARGET_NORMAL_MODE
&& h8300_regs_ok_for_stm (4, operands)"
"
It seems to me that the test for !TARGET_NORMAL_MODE in the expander's
condition does not belong and should be removed. If you could test
that and verify the H8 port still works correctly, it would be
greatly appreciated.
jeff