This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add -iquote support


On Monday, May 3, 2004, at 05:29 PM, Zack Weinberg wrote:
A few changes needed:

1) You removed the processing of -I- entirely.  Better it should
   produce an error.

Done.


  (Which means that you need to leave the note
   about using -I./- if you really mean search a directory named "-"
   in the documentation.)

Done.


2) The comment at the head of remove_duplicates, explaining why we
   can't merge the lists and then uniquize them, shouldn't be removed;
   it's still true.  Just change the notation.

Done.


3) You removed the logic that sets quote_ignores_source_dir but you
did not remove the logic that uses it, which is now dead; please do so.

Done.


4) This requires an entry in the "Differences from previous versions"
   section of the CPP manual

Done.


and an entry in the 3.5 release notes;

Done.


   and, as I said, a loud public announcement (suggest posting to
   gcc-announce).

Can we wordsmith this after the main patch goes in? If not, do you have anything you'd like in it?


I'd just say something like:

-I- will be removed in gcc 3.5. Users that want to object are invited to contact gcc@gcc.gnu.org. -iquote is meant to replace the use of -I-. See <insert html link to generated html doc and gcc patches discussion here> for details.

And like the ChangeLog, I'm happy to write it and send it out, but I will not be putting my name on it, as I don't want to be associated with the removal of a feature a user might be using. Whose names should I put on it?

5) Why are you messing with g77?

Removed from the diff.


Attachment: iquote-b.diffs.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]