This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/Patch] Support DWARF 2 for cygming (PE)


I'm sure this is too much detail, but given I'm new at this...

On Thu, 29 Apr 2004, Christopher Faylor wrote:

> On Wed, Apr 28, 2004 at 06:55:20PM -0500, Brian Ford wrote:
> >2004-04-28  Brian Ford  <ford@vss.fsi.com>
> >            DJ Delorie  <dj@redhat.com>
> >
> >	* config/i386/cygming.h [HAVE_GAS_PE_SECREL32_RELOC]
> >	(DWARF2_DEBUGGING_INFO): Define to enable.
> >	(DBX_REGISTER_NUMBER): Define to use the svr4 register map for
> >	DWARF2.
> >	* configure.ac (Target-specific assembler checks)
> >	<i[34567]86-*-[cygwin*|pe|mingw32*]>: New test for .secrel32
> >	relocs.
> >	* configure: Regenerate.
> >	* config.in: Likewise.
> >
> >	* config/i386/cygming.h [HAVE_GAS_PE_SECREL32_RELOC]
> >	(ASM_OUPUT_DWARF_OFFSET): Define.
>
> Please check in.

Done, with the following two trivial changes:

Index: configure.ac
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.ac,v
retrieving revision 2.34
diff -u -p -r2.34 configure.ac
--- configure.ac        30 Apr 2004 18:50:27 -0000      2.34
+++ configure.ac        30 Apr 2004 18:58:59 -0000
@@ -2544,7 +2544,7 @@ changequote([,])dnl
        # Used for DWARF 2 in PE
        gcc_GAS_CHECK_FEATURE([.secrel32 relocs],
          gcc_cv_as_ix86_pe_secrel32,
-         [2,16,0],,
+         [2,15,91],,
 [.text
 foo:   nop
 .data
Index: config/i386/cygming.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/cygming.h,v
retrieving revision 1.15
diff -u -p -r1.15 cygming.h
--- config/i386/cygming.h       30 Apr 2004 18:50:27 -0000      1.15
+++ config/i386/cygming.h       30 Apr 2004 19:00:13 -0000
@@ -35,7 +35,7 @@ Boston, MA 02111-1307, USA.  */

 /* Use section relative relocations for debugging offsets.  Unlike
    other targets that fake this by putting the section VMA at 0, PE
-   won't allow it. */
+   won't allow it.  */
 #define ASM_OUTPUT_DWARF_OFFSET(FILE, SIZE, LABEL)    \
   do {                                                \
     if (SIZE != 4)                                    \

The regenerated configure script appears to have several of these:

RCS file: /cvs/gcc/gcc/gcc/configure,v
retrieving revision 1.821
retrieving revision 1.822
diff -u -p -r1.821 -r1.822
--- configure   30 Apr 2004 00:33:18 -0000      1.821
+++ configure   30 Apr 2004 18:50:27 -0000      1.822
@@ -2354,7 +2354,8 @@ if { (eval echo "$as_me:$LINENO: \"$ac_c
   cat conftest.err >&5
   echo "$as_me:$LINENO: \$? = $ac_status" >&5
   (exit $ac_status); } &&
-        { ac_try='test -z "$ac_c_werror_flag"                   || test !
-s conftest.err'
+        { ac_try='test -z "$ac_c_werror_flag"
+                        || test ! -s conftest.err'
   { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
   (eval $ac_try) 2>&5
   ac_status=$?

I assume they are due to differing autoconf versions (I used Cygwin's
2.59).  Since they looked cleaner this way, I didn't hand edit them out.

I also applied the following:

2004-04-30  Brian Ford  <ford@vss.fsi.com>

        * MAINTAINERS (Write After Approval): Add myself.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.354
retrieving revision 1.355
diff -u -p -r1.354 -r1.355
--- MAINTAINERS 29 Apr 2004 07:06:46 -0000      1.354
+++ MAINTAINERS 30 Apr 2004 18:11:53 -0000      1.355
@@ -211,6 +211,7 @@ Mohan Embar
gnustuff@thisiscool.com
 Marc Espie                                     espie@cvs.openbsd.org
 Ansgar Esztermann
ansgar@thphy.uni-duesseldorf.de
 Doug Evans                                     dje@transmeta.com
+Brian Ford                                     ford@vss.fsi.com
 Kaveh Ghazi                                    ghazi@caip.rutgers.edu
 Matthew Gingell                                        gingell@gnat.com
 Anthony Green                                  green@redhat.com

Please let me know if any of this was incorrect.

> P.S.  Yay!  Dwarf2 on cygwin finally!

Thanks!  Now, if I can only get my last two gdb patches approved :-).

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
the best safety device in any aircraft is a well-trained pilot...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]