This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [arm] Automate --with-cpu
- From: neroden at twcny dot rr dot com (Nathanael Nerode)
- To: gcc-patches at gcc dot gnu dot org, paul at codesourcery dot com
- Date: Thu, 29 Apr 2004 11:42:10 -0400
- Subject: Re: [arm] Automate --with-cpu
I like the concept, but:
+ # See if it matches any of the entries in arm-cores.def
eval "val=\$with_$which"
! [ x"$val" = x ] && val=unset
! for opt in `sed -e '/ARM_CORE/!d' \
! -e 's/ARM_CORE(\([^,]*\),.*$/\1/' \
! ${srcdir}/config/arm/arm-cores.def` unset .
! do
! [ x$opt = x"$val" ] && break
! done
Isn't there a clearer way to write this logic? It's hideously unreadable.
--
There are none so blind as those who will not see.