This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] improve decisions about running vmx tests


On Thu, Apr 22, 2004 at 05:25:50PM -0700, Zack Weinberg wrote:
> Janis Johnson <janis187@us.ibm.com> writes:
> 
> > Here's an updated version which I believe addresses all of the concerns
> > that were brought up with yesterday's version.  In particular, the
> > names of the temporary files now include the pid so they'll be unique
> > for each testsuite that uses these tests.  If this looks like a good
> > solution to that issue then I'll submit a separate patch for the other
> > tmp.c and tmp.x files in target-supports.exp.  It turns out that puts
> > already adds a newline, so I removed the extra ones.
> 
> ...
> 
> > +	set p [pid]
> > + 	regsub "xxx" "tmp_xxx.c" $p sname
> > + 	regsub "xxx" "tmp_xxx.x" $p xname
> > + 	regsub "xxx" "./tmp_xxx.x" $p dxname
> 
> Why not just
> 
> set sname  "tmp_[pid].c"
> set xname  "tmp_[pid].x"
> set dxname "./$xname"
> 
> ?

Because I don't know Tcl well enough to know that's possible.  I'll
do that.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]