This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix PR 14992

From: Mark Mitchell <mark at codesourcery dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 22 Apr 2004 09:39:31 -0700
Subject: Re: Fix PR 14992
Organization: CodeSourcery, LLC
References: <20040418154702.GH2973@bubble.modra.org> <20040422120919.GA2531@bubble.modra.org>

Alan Modra wrote:

On Mon, Apr 19, 2004 at 01:17:02AM +0930, Alan Modra wrote:

PR bootstrap/14992

This is the version I'd like to apply to mainline.

	* gcc.c (init_gcc_specs): Test USE_LD_AS_NEEDED, not HAVE_LD_AS_NEEDED.
	* config/linux.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/alpha/linux.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/arm/linux-elf.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/rs6000/linux.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/rs6000/linux64.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/sh/linux.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/sparc/linux.h (USE_LD_AS_NEEDED): Define.
	* gcc/config/sparc/linux64.h (USE_LD_AS_NEEDED): Define.

Tested i686-linux and powerpc-linux.

This is almost OK.

But, while you're here, you should provide a default definition of USE_LD_AS_NEEDED and make the #ifdef in gcc.c into an #if. That way USE_LD_AS_NEEDED can be tested within "if" as well as #if in the future.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

References:
- Fix PR 14992
  - From: Alan Modra
- Re: Fix PR 14992
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]