Re: [tree-ssa] [PATCH] Do no rebuild libbanshee on PPC-Darwin

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Apr 1, 2004, at 16:46, Daniel Berlin wrote:
> On Apr 1, 2004, at 4:42 PM, Richard Henderson wrote:
>
> > On Thu, Apr 01, 2004 at 04:26:24PM -0500, Andrew Pinski wrote:
> > > 	* config.gcc (powerpc-*-darwin*): Do not
> > > 	rebuild libbanshee.
> >
> > Doesn't this mean there's other code elsewhere that performed the
> > rebuild that is now trash?
>
> Yes, unless there are other platforms in the same boat.
>
> I assumed there were, and we just never noticed them before.
> If there aren't, there is gcc/*.in code that is now useless.

If there are any other targets like this, they should be fixed to
include the functions in libgcc or link against the libraries that
is needed.

Here this patch which removes the support from configure and the 
Makefile.

Thanks,
Andrew Pinski

ChangeLog:
	* Makefile.in (stage2_build): Remove support for
	rebuilding libbanshee.
	* configure.ac: Remove support for rebuilding
	libbanshee.
	* config.gcc (powerpc-*-darwin*): Do not rebuild
	libbanshee.


Patch:
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.903.2.197
diff -u -p -r1.903.2.197 Makefile.in
--- Makefile.in	26 Mar 2004 16:21:26 -0000	1.903.2.197
+++ Makefile.in	2 Apr 2004 01:02:58 -0000
@@ -3585,7 +3585,6 @@ stage1_copy: stage1_build
 	echo stage2_build > stage_last

 stage2_build: stage1_copy
-	@BANSHEEREBUILD@
 	$(MAKE) CC="$(STAGE_CC_WRAPPER) stage1/xgcc$(exeext) -Bstage1/ 
-B$(build_tooldir)/bin/" CC_FOR_BUILD="$(STAGE_CC_WRAPPER) 
stage1/xgcc$(exeext) -Bstage1/ -B$(build_tooldir)/bin/" \
 		 STAGE_PREFIX=stage1/ \
 		 $(POSTSTAGE1_FLAGS_TO_PASS) \
Index: configure.ac
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.ac,v
retrieving revision 2.10.2.8
diff -u -p -r2.10.2.8 configure.ac
--- configure.ac	29 Mar 2004 17:38:37 -0000	2.10.2.8
+++ configure.ac	2 Apr 2004 01:02:58 -0000
@@ -2807,16 +2807,10 @@ if test x"$libbanshee" = xyes; then
 	BANSHEELIB="../libbanshee/points-to/libandersen.a 
../libbanshee/engine/libbansheeengine.a 
../libbanshee/libcompat/libbansheecompat.a "
 	BANSHEEINC="-I\$(srcdir)/../libbanshee/libcompat 
-I\$(srcdir)/../libbanshee -I\$(srcdir)/../libbanshee/points-to"
 	ANDER="tree-alias-ander.o"
-	if test x$rebuild_banshee = xyes; then
-		BANSHEEREBUILD="s=\${PWD}; export s && cd ../libbanshee && echo 
\${PWD} && \$(MAKE) clean && \$(MAKE) CC=\"\$(STAGE_CC_WRAPPER) 
\$\$s/stage1/xgcc\$(exeext) -B\$\$s/stage1/ -B\$(build_tooldir)/bin/\" 
\$(STAGE2_FLAGS_TO_PASS) && cd ../gcc"
-	else
-		BANSHEEREBUILD=""
-	fi
 	AC_DEFINE(HAVE_BANSHEE, 1, [Define if BANSHEE is available])
 else
 	BANSHEELIB=""
 	BANSHEEINC=""
-	BANSHEEREBUILD=""
 	ANDER=""
 fi
 AC_MSG_RESULT($with_libbanshee)
@@ -2824,7 +2818,6 @@ AC_MSG_RESULT($with_libbanshee)
 AC_SUBST(ANDER)
 AC_SUBST(BANSHEEINC)
 AC_SUBST(BANSHEELIB)
-AC_SUBST(BANSHEEREBUILD)

 # --------------
 # Language hooks
Index: config.gcc
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config.gcc,v
retrieving revision 1.215.2.51
diff -u -p -r1.215.2.51 config.gcc
--- config.gcc	26 Mar 2004 16:21:47 -0000	1.215.2.51
+++ config.gcc	2 Apr 2004 01:02:58 -0000
@@ -1506,7 +1506,6 @@ powerpc-*-darwin*)
 	tm_file="${tm_file} rs6000/darwin.h"
 	tmake_file="${tmake_file} rs6000/t-darwin"
 	extra_headers=altivec.h
-	rebuild_banshee=yes
 	;;
 powerpc*-*-freebsd*)
 	tm_file="${tm_file} dbxelf.h elfos.h ${fbsd_tm_file} rs6000/sysv4.h 
rs6000/freebsd.h"