This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Add some more builtins opts for sqrt/cbrt


 > From: David Edelsohn <dje@watson.ibm.com>
 > 
 > 	builtin-power-1.c is failing on PowerPC.  [...]
 > 
 > It also is failing on Darwin, along with other builtins.
 > David

The darwin failure is different.  It occurs because there is a
mismatch in whether GCC thinks darwin has C99 functions between the
darwin port itself and the testsuite.  Fixing this will correct much
more than just builtin-power-1.c.  As you noted, there are several
builtins failures on darwin.

If darwin has the C99 functions, then someone needs to add
#define TARGET_C99_FUNCTIONS 1
to config/darwin.h.

If darwin doesn't have the C99 functions, then someone needs to tweek
testsuite/gcc.dg/builtins-config.h appropriately so darwin doesn't
attempt to test any transformations which result in C99 function
calls.

Either way, someone who knows darwin and can test on it should fix
this.

		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]