This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GCC_NO_EXECUTABLES in libbanshee/configure.in


Daniel Jacobowitz <drow@false.org> writes:

> On Fri, Mar 26, 2004 at 09:21:32AM +0100, Andreas Jaeger wrote:
>> Diego Novillo <dnovillo@redhat.com> writes:
>> 
>> > Andreas,
>> >
>> > According to cvs ann, you added GCC_NO_EXECUTABLES to configure.in back
>> > in Feb29.  We get an error from that line when configuring the branch
>> >
>> > src/libbanshee/configure: line 2882: GCC_NO_EXECUTABLES: command not found
>> >
>> > However, things seem to work just the same.
>> >
>> > Could you take a look?
>> 
>> Oops, I've never seen that before - but it appears here also.
>> 
>> Can you try the appended patch?  I'm CC'ing gcc-patches to get your
>> approval ;-)
>> 
>> This patch works for me (just tested on x86_64-linux-gnu).
>> 
>> Ok to commit?
>
>
>> +# The autoconf 2.5x version of the no-executables hack.
>> +sinclude(../config/no-executables.m4)
>> +GCC_NO_EXECUTABLES
>> +
>
> In Autoconf 2.59, we can probably use AC_NO_EXECUTABLES instead.  It
> should be basically the same as GCC_NO_EXECUTABLES.
>
> But why does libbanshee need this at all?  It's not a target library;
> if all you want is $GCC, then AC_PROG_CC will set it.

I thought we needed it.  OK, in this case the following patch should
be just enough.

Tested on Linux/x86-64 and committed as obvious,

Andreas

============================================================
Index: ChangeLog
--- ChangeLog	8 Mar 2004 00:09:26 -0000	1.1.2.9
+++ ChangeLog	26 Mar 2004 17:30:03 -0000
@@ -1,3 +1,8 @@
+2004-03-26  Andreas Jaeger  <aj@suse.de>
+
+        * configure.in: Remove GCC_NO_EXECUTABLES.
+        * configure: Regenerated.
+
 2004-03-07  Daniel Berlin  <dberlin@dberlin.org>
 
 	* engine/Makefile.am (AM_CFLAGS): Add -I$(top_srcddir)/../include, so we
============================================================
Index: configure.in
--- configure.in	29 Feb 2004 17:20:33 -0000	1.1.2.5
+++ configure.in	26 Mar 2004 17:30:03 -0000
@@ -13,7 +13,6 @@ AC_PROG_RANLIB
 # FIXME: Replace `main' with a function in `-lm':
 #AC_CHECK_LIB([m], [main])
 
-GCC_NO_EXECUTABLES
 
 if test x$GCC = xyes; then
   ac_libbanshee_warn_cflags='-W -Wall -pedantic -Wwrite-strings  -Wstrict-prototypes -Wmissing-prototypes'
============================================================
Index: configure
--- configure	29 Feb 2004 17:20:33 -0000	1.1.2.9
+++ configure	26 Mar 2004 17:30:05 -0000
@@ -2879,7 +2879,6 @@ fi
 # FIXME: Replace `main' with a function in `-lm':
 #AC_CHECK_LIB([m], [main])
 
-GCC_NO_EXECUTABLES
 
 if test x$GCC = xyes; then
   ac_libbanshee_warn_cflags='-W -Wall -pedantic -Wwrite-strings  -Wstrict-prototypes -Wmissing-prototypes'

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]