This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Add ctype builtin declarations
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: roger at eyesopen dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 25 Mar 2004 10:59:35 -0500 (EST)
- Subject: Re: [PATCH]: Add ctype builtin declarations
- References: <Pine.LNX.4.44.0403250638470.28065-100000@www.eyesopen.com>
> From: Roger Sayle <roger@eyesopen.com>
>
> On Thu, 25 Mar 2004, Kaveh R. Ghazi wrote:
> > 2004-03-25 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * builtins.def: Add ctype builtins.
> > * doc/extend.texi: Likewise.
> > * gcc.dg/torture/builtin-ctype-1.c: New test.
> >
>
> Ok for mainline.
>
Thanks.
> Language standards aren't my area of expertise, but the newlib man
> pages state that "isascii" is ANSI C, but "toascii" is not. Could
> you double check that BUILT_IN_ISASCII shouldn't be DEF_LIB_BUILTIN
> instead of DEF_EXT_LIB_BUILTIN?
According to the Open Group reference:
http://www.opengroup.org/onlinepubs/007904975/functions/isascii.html
as well as the glibc ctype.h header:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/ctype/ctype.h?rev=1.45&content-type=text/x-cvsweb-markup&cvsroot=glibc
isascii (and toascii) are creatures of SVID & X/OPEN.
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu