Re: [patch] Local factoring algorithms

[Gábor Lóki <loki at inf dot u-szeged dot hu>]

Eric Christopher wrote:

> A couple of style comments:
> > + /* Initialization of the chain of bbDecorator! For each bb there is a
> > +    bbDecorator in the chain.  */
> This is the way comments should be formatted. This is also about the
> only one in the file this way :)
>
> > + static bbDecorator
> > + init (bbDecorator decorator)
> init_factoring maybe? Probably a silly request, but...

Thanks. I'll correct these.

> Another question people will have are the compile and runtime effects.
> Have you timed a run of, say, SPEC with this?

I've not measured with SPEC yet, but IMO there shouldn't be any slow 
down for runtime.
In the CSiBE results the compilation time does not increase
significantly (about 0.5%).

Regards,
  Gábor Lóki