This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ patch] [PR 9283] Implement per-class visibility attribute [resend]


Sorry I've taken so long to review this.

Why did you decide to store so much information in current_class_stack?  It
would seem simpler to me just to look up the relevant attributes when
needed.  I suppose that caching the class visibility in current_class_stack
might speed things up slightly, but the visibility_overrides scheme seems
slower than just looking for a visibility attribute on the decl.

Jason



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]