This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] [tree-ssa] Fix handling of BIT_FIELD_REFs andVECTOR_TYPEs
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Mar 2004 11:03:50 -0500
- Subject: Re: [RFC] [tree-ssa] Fix handling of BIT_FIELD_REFs andVECTOR_TYPEs
- Organization: Red Hat Canada
- References: <405F60FB.2080708@polimi.it>
On Mon, 2004-03-22 at 16:56, bonzini wrote:
> Unfortunately, I don't. These (seems to me) bugs are exposed by my work
> to lower vectors into scalars if there is no instruction for that. That
> code puts BIT_FIELD_REFs of VECTOR_TYPE variables in the left side of
> MODIFY_EXPRs, like
>
I *think* I've seen BIT_FIELD_REFs on the LHS of assignments and we were
DTRT, because the variable was already marked non-gimple. So, it seems
to me that just marking VECTOR_TYPE as non-gimple ought to suffice.
If you have time, could you insert a probe in verify_stmts to abort when
we see BIT_FIELD_REF on the LHS of an assignment? I'm almost sure you
will hit it in a typical bootstrap.
That would be a good check to add to verify_stmts, BTW. Making sure
that BIT_FIELD_REF operands are non-gimple variables.
Thanks. Diego.