This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [WWW PATCH] [PR14618] Document new access checking performed byg++


On Thu, 18 Mar 2004, Giovanni Bajo wrote:
> Index: bugs.html
> ===================================================================
> + <dt><a name="known_cxx_rvalbind">Copy constructor access check while
> + initializing a reference.</a></dt>

Perhaps omit "known_" in the name to keep it shorter and easier to type?

> + <p>Starting from GCC 3.4.0, binding a rvalue to a const reference requires

"Starting with"?

"an rvalue"

> + an accessible copy constructor. This might be surprising at first sight,
> + especially since most popular compilers do not implement correctly this
> + rule.</p>

"correctly implement"

> + <p>For further information, you can consult the following paragraph of

"paragraphs"?

> +  This might be surprising at first sight, especially since most
> +  popular compilers do not implement correctly this rule. Please,
> +  consult <a href="http://gcc.gnu.org/bugs.html#known_cxx_rvalbind";>
> +  this page</a> for a more exhaustive explanation of this non-bug.</li>

How about:

 +  This might be surprising at first sight, especially since most
 +  popular compilers do not implement correctly this rule
 +  (<a href="../bugs.html#known_cxx_rvalbind">further details</a>).

? This makes the link relative, and avoids having "this page" as a link,
which we should avoid due to usability concerns.


The patch is fine with these changes (or others which address my
comments).

Thanks, also to Gaby!

Gerald
-- 
Gerald "Jerry"   pfeifer@dbai.tuwien.ac.at   http://www.pfeifer.com/gerald/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]