This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PING: PATCH [mainline] speed up comparing enums declared in multiple translation units



Now that Dale's IMA patch has been approved, this patch is needed for SPEC testing with IMA.
It is a localized patch and will have no impact anywhere else.

- fariborz (fjahanian@apple.com)

Begin forwarded message:

From: Fariborz Jahanian <fjahanian@apple.com>
Date: March 12, 2004 10:21:39 AM PST
To: gcc-patches@gcc.gnu.org
Cc: Fariborz Jahanian <fjahanian@apple.com>
Subject: PATCH [mainline] speed up comparing enums declared in multiple translation units


Made changes suggested by rth and A. Pinski. Revised is attached.

OK for mainline?

- fariborz jahanian (fjahanian@apple.com)


This is a performance bug fix which prevents mesa (SPEC program) to compile with IMA in a
reasonable amount of time. Performance hit is comparing two enumerated types declared in
different translation unit. Fix is in routine tagged_types_tu_compatible_p and uses
the infrastructure already there to prevent recursion when comparing composite types.
Essentially it remembers previous comparison results of the two enum types and uses the
saved result. bootstrapped, dejagnu tested on ppc-darwin. Furthermore, tested against
SPEC benchmark with IMA. mesa now takes minutes to compile, instead of days (on my
particular G5 machine anyway).


ChangeLog:

2004-03-09 Fariborz Jahanian <fjahanian@apple.com>
* c-typeck.c (tagged_types_tu_compatible_p): speed up type
comparison of enums declared in separate tus.


Attachment: ima-mesa-patch-3.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]