Re: [PATCH] [COMMITTED] Fix bootstrap on powerpc-apple-darwin

[Ian Lance Taylor <ian at wasabisystems dot com>]

Andreas Tobler <toa@pop.agri.ch> writes:

> Ian,
> 
> thanks, this brings darwin6.8 further.
> 
> Ian Lance Taylor wrote:
> 
>   ret = mmap_result == (void *) MAP_FAILED;
> 
> > +      /* Sanity check for broken MAP_FIXED.  */
> > +      if (ret && mmap_result != addr)
> > +	abort ();
> > +    }
> 
> Could anyone please explain me this a bit more.
> 
> This sanity check I don't understand.
> 
> This check aborts if ret == 1 because mmap_result = 0xffffffff and
> address != 1, it also aborts if ret == 0 because mmap_result is
> something and address != 0.
> 
> Maybe it's too late but I spent quite a while and I don't get this
> routine into my understanding. I'd be happy if someone could explain
> me.

Yes, it should presumably be
      ret = mmap_result != (void *) MAP_FAILED;

Ian