This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PPC{,64} debug info for __thread variables


On Fri, Mar 12, 2004 at 10:24:58AM -0500, David Edelsohn wrote:
> +    case 8:
> +      fputs ("\t.llong\t", file);
> 
> 	I thought the DOUBLE_INT_ASM_OP for powerpc-linux and
> powerpc64-linux was ".quad".  Also, this function probably should use
> DOUBLE_INT_ASM_OP instead of duplicating the string.  If it needs
> ".llong", I would like to know why.

Both .llong and .quad work the same, but .8byte does not work
in binutils with @dtprel (.8byte is a generic gas directive, while
.llong and .quad are PPC specific ones).

> +/* Emit a dtp-relative reference to a TLS variable.  */
> +
> +#ifdef HAVE_AS_TLS
> +#define ASM_OUTPUT_DWARF_DTPREL(FILE, SIZE, X) \
> +  rs6000_output_dwarf_dtprel (FILE, SIZE, X)
> +#endif
> 
> 	I guess defining this in rs6000.h instead of linux.h and
> linux64.h, or at least sysv4.h, is forward-looking when other systems
> support TLS?

Yes.

> Okay with the DOUBLE_INT_ASM_OP change, assuming .quad change is correct.
> Otherwise, there probably is something wrong.

I've commited the patch with DOUBLE_INT_ASM_OP instead of "\t.llong\t",
thanks.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]