This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] remove get_base_var/get_base_decl


On Thu, 2004-03-11 at 00:30, Richard Henderson wrote:
> There was exactly one valid use of these functions, the one in set_is_used.
> Even there, it might be better to use walk_tree, since we're not currently
> marking the index of ARRAY_REFs.  Andrew, is that something we should be
> concerned about in callers of this function?
> 

I think all my uses of set_is_used() are guaranteed to be on operands or
PHI componenets. So as long as we are marking indexes which are
variables as operands, (which we must be) it ought to be OK.
set_is_used() ought only be called on scalar variables used as operands
or PHI results/arguments. Things that end up in partitions.

Can we get a non-scalar in a non-virtual PHI? I recently learned we can
have more than I expected there... in the form of constant expressions.
I can't picture there being a scalar variable we care about in a
constant expression...

We ought to be OK.
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]