This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Committed: Fix typos in config/accross.m4


For cris-axis-elf, linking with -O2 or -O3 implies --gc-sections, so the
interesting arrays disappeared and the test failed, which exposed the
second bug.  If you can't immediately see the problem, hopefully the
expansion makes it clearer:
echo "$as_me: error: unknown endianess - sorry" >&2;}
   { (exit please pre-set ac_cv_c_bigendian); exit please pre-set ac_cv_c_bigendian; }; }

The interesting bits are for gcc/ and libiberty/ are tested on
lots of sims, for example cris-axis-elf, mmix-knuth-mmixware
(different endians).  (Someone broke landing pads for MMIX so I
checked C only to exercise the big-endian test on something
other than powerpc.  Film at 11.)  Because the regens for libffi
and fastjar could theoretically cause problem, I also tested on
native i686-pc-linux-gnu.  Committed as obvious; the conftest.o
makes it obvious that -c was intended, and only gcc is supported
as a cross-compiler so -c -o is guaranteed to work.

config/ChangeLog:

	* accross.m4 (AC_C_BIGENDIAN_CROSS): Compile endian probe with
	"-c".  Properly quote parameter for AC_MSG_ERROR.

libiberty/ChangeLog:
	* configure: Regenerate for config/accross.m4 correction.
fastjar/ChangeLog:
	* configure: Regenerate for config/accross.m4 correction.
gcc/ChangeLog:
	* configure: Regenerate for config/accross.m4 correction.
libffi/ChangeLog:
	* configure: Regenerate for config/accross.m4 correction.


--- accross.m4	Mon Mar  8 00:44:55 2004
+++ accross.m4.x	Sat Sep  6 18:00:22 2003
@@ -64,7 +64,7 @@ void _ebcdic() { char* s = (char*) ebcdi
 int main() { _ascii (); _ebcdic (); return 0; }
 EOF
 ] if test -f conftest.c ; then
-     if ${CC-cc} ${CFLAGS} conftest.c -o conftest.o && test -f conftest.o ; then
+     if ${CC-cc} ${CFLAGS} -c conftest.c -o conftest.o && test -f conftest.o ; then
         if test `grep -l BIGenDianSyS conftest.o` ; then
            echo $ac_n ' big endian probe OK, ' 1>&AC_FD_MSG
            ac_cv_c_bigendian=yes
@@ -93,6 +93,6 @@ else
 fi
 AC_DEFINE_UNQUOTED(BYTEORDER, $BYTEORDER, [1234 = LIL_ENDIAN, 4321 = BIGENDIAN])
 if test $ac_cv_c_bigendian = unknown; then
-  AC_MSG_ERROR(unknown endianess - sorry, please pre-set ac_cv_c_bigendian)
+  AC_MSG_ERROR([unknown endianess - sorry, please pre-set ac_cv_c_bigendian])
 fi
 ])

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]