This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH to TYPE_HASH

From: Jason Merrill <jason at redhat dot com>
To: Zack Weinberg <zack at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 06 Mar 2004 01:57:36 -0500
Subject: Re: PATCH to TYPE_HASH
References: <xyphdx2ylcu.fsf@miranda.boston.redhat.com><87ad2uanxs.fsf@egil.codesourcery.com>

On Fri, 05 Mar 2004 15:12:15 -0800, Zack Weinberg <zack@codesourcery.com> wrote:

> Jason Merrill <jason@redhat.com> writes:
>
>> As previously mentioned, the canonical type hash table doesn't work
>> very well with PCH because the hash codes are based on tree
>> addresses which are not consistent over PCH save and load.  This
>> patch changes TYPE_HASH to use TYPE_UID instead of the address.
>
> Please don't; I intend(ed) to kill TYPE_UID.

Well, then it seems to me that you get to come up with another solution for
hashing types across PCH.  This strategy is what Geoff suggested.

Jason

Follow-Ups:
- Re: PATCH to TYPE_HASH
  - From: Zack Weinberg
- Re: PATCH to TYPE_HASH
  - From: Mark Mitchell

References:
- PATCH to TYPE_HASH
  - From: Jason Merrill
- Re: PATCH to TYPE_HASH
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]