This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATH COMMITTED: Minor bug in configury patch


Geoff Keating <geoffk@apple.com> writes:

> > This patch to configure.ac:
> >
> >     http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01592.html
> >
> > 2004-02-17  Geoffrey Keating  <geoffk@apple.com>
> >
> > 	* configure.ac: When generating auto-build.h, pass
> > 	--enable-languages to the sub-configure.
> > 	Put quotes around ${program_transform_name} when generating
> > 	name of as, ld, nm, objdump.
> > 	* configure: Regenerate.
> >
> > fails when --enable-languages is not used at all when doing a
> > Canadian Cross build.  The sub-configure gets an error:
> >     --enable-languages needs at least one language argument
> >
> > The appended patch fixes the problem.  Committed as obvious.
> 
> Doesn't this chunk of code:
> 
> if test x"${enable_languages+set}" != xset; then
>          if test x"${LANGUAGES+set}" = xset; then
>                  enable_languages="${LANGUAGES}"
>                  AC_MSG_WARN([setting LANGUAGES is deprecated, use
> --enable-langu
> ages instead])
> 
>          else
>                  enable_languages=all
>          fi
> 
> ensure that enable_languages always has a value?

Yes, I suppose it does, and if that piece of code appeared before the
recursive call to configure, then I suppose there wouldn't be a
problem.

Perhaps I misidentified the source of the bug.  Perhaps the source of
the bug was actually Nathanael's rearranging of configure.ac.  I tried
building with a cross-compiler, and it failed, and the lines in
question were added recently, and I assumed they were the culprit.
Sorry about that.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]