This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Give a better error for PCH with exec-shield-randomize
Richard Henderson <rth@redhat.com> writes:
> On Fri, Mar 05, 2004 at 12:41:43PM -0500, Ian Lance Taylor wrote:
> > I think this patch should be checked into mainline. This removes a
> > potential problem on Linux systems on which mincore won't detect a
> > conflict. It should do no harm, since Linux systems don't appear to
> > need this particular workaround.
>
> Do we have any evidence that anyone besides Solaris needs this
> workaround? In my local tree I've moved all the mincore stuff
> into a host-solaris.c file. I'm unsure whether that's a mistake...
I don't know either. The hint parameter to mmap() was never more than
a hint, and I think MAP_FIXED has always overridden other mappings, so
it is at least possible that some other system will require it. But
in practice I don't know.
Ian