This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch:3.3 branch] Fix sysroot logic in cppinit.c
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: 02 Mar 2004 14:44:19 +0100
- Subject: Re: [Patch:3.3 branch] Fix sysroot logic in cppinit.c
- Organization: Integrable Solutions
- References: <20040229212110.93876.qmail@web61007.mail.yahoo.com>
Danny Smith <danny_r_smith_2001@yahoo.co.nz> writes:
| Hi
|
| This patch to gcc-3.3 branch:
|
| 2003-11-06 H.J. Lu <hongjiu.lu@intel.com>
|
| * cppinit.c (init_standard_includes): Updated.
| <...>
| which backported the sysroot functionality from 3.4 causes problems
| with relocatability of gcc toolset on mingw targets.
|
| In cppinit.c (init_standard_includes), the conditional
|
| if (p->add_sysroot && CPP_OPTION (pfile, sysroot))
| continue;
|
| is always true, because CPP_OPTION (pfile, sysroot) expands to
| this default (in cppdefault.c)
|
| const char *cpp_SYSROOT = "";
|
| We need to check that *cpp_SYSROOT is not '\0'.
|
| In 3.4 branch, the logic is slightly diferemt and check for a NULL pointer
| is sufficient.
|
| The following patch is agaainst gcc-3.3.3 release.
Did I say OK? If not, please apply.
-- Gaby