This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Strip '=' from multilib directory names


More than once people have run into trouble when a multilib subdir name
is passed through make/shell interpretation and expansion.  Why not just
sidestep the problem altogether?

My feeling -- and a straw poll on #gcc indicates informal agreement --
is that the multilib directory named are behind the scenes, part of a
black box.  Users shouldn't care, and if they're writing a tool (or a
script, or a makefile) which needs to /predict/ what the name is, they
can use -print-multi-dir to find out.  If they're writing something which
needs to /examine/ the names, they -- more to the point, "we" -- should
be able to do so without triggering variable assignments in bad places.


2004-03-01  Phil Edwards  <phil@codesourcery.com>

	* genmultilib:  Strip '=' when translating option names to
	directory names.


Index: genmultilib
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/gcc/genmultilib,v
retrieving revision 1.14
diff -u -p -r1.14 genmultilib
--- genmultilib	20 Dec 2003 07:40:21 -0000	1.14
+++ genmultilib	2 Mar 2004 00:18:07 -0000
@@ -311,7 +311,7 @@ for combo in ${combinations}; do
   if [ -n "${todirnames}" ]; then
     dirout=`echo ${combo} | sed ${todirnames}`
   else
-    dirout=${combo}
+    dirout=`echo ${combo} | sed -e 's/=//g'`
   fi
   # Remove the leading and trailing slashes.
   dirout=`echo ${dirout} | sed -e 's|^/||' -e 's|/$||g'`


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]