This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: A Far Less Ambitious AltiVec patch
- From: Geoff Keating <geoffk at desire dot geoffk dot org>
- To: zlaski at apple dot com
- Cc: zlaski at ziemas dot net, gcc-patches at gcc dot gnu dot org, segher at kernel dot crashing dot org
- Date: Fri, 20 Feb 2004 13:49:58 -0800
- Subject: Re: PING: A Far Less Ambitious AltiVec patch
- References: <6FCF1F56-4D16-11D8-B987-00039390FFE2@ziemas.net> <jm7jyibl19.fsf@desire.geoffk.org> <44CC32E7-6374-11D8-AC64-00039390FFE2@ziemas.net> <jmy8qxa332.fsf@desire.geoffk.org> <1C4D05F8-63E8-11D8-B9A3-000393673036@apple.com>
> X-Original-To: geoffk@foam.wonderslug.com
> Cc: Ziemowit Laski <zlaski@ziemas.net>, gcc-patches@gcc.gnu.org,
> Segher Boessenkool <segher@kernel.crashing.org>
> From: Ziemowit Laski <zlaski@apple.com>
> Date: Fri, 20 Feb 2004 13:02:36 -0800
> X-OriginalArrivalTime: 20 Feb 2004 21:10:20.0375 (UTC) FILETIME=[F27BBE70:01C3F7F5]
>
>
> On 20 Feb, 2004, at 12.49, Geoff Keating wrote:
> >>>
> >>> --- 8960,8966 ----
> >>> || REGNO (XEXP (x, 0)) >= 32)
> >>> output_operand_lossage ("invalid %%P value");
> >>> else
> >>> ! fprintf (file, "%s", reg_names[REGNO (XEXP (x, 0))]);
> >>> return;
> >>>
> >>> case 'q':
> >>>
> >>> You should update the comment immediately above this code.
> >>
> >> The latest version looks like this:
> >>
> >> --- 9019,9031 ----
> >> || REGNO (XEXP (x, 0)) >= 32)
> >> output_operand_lossage ("invalid %%P value");
> >> else
> >> + #if TARGET_MACHO
> >> + /* The Darwin assembler requires a register name rather than
> >> + merely a number. */
> >> + fprintf (file, "%s", reg_names[REGNO (XEXP (x, 0))]);
> >> + #else
> >> fprintf (file, "%d", REGNO (XEXP (x, 0)));
> >> + #endif
> >> return;
> >>
> >
> > That's worse. Use reg_names always.
>
> I can't -- non-Darwin assemblers will barf on it.
No, they won't. Try it and see.
--
- Geoffrey Keating <geoffk@geoffk.org>