This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ia64-hpux fix compat/struct-by-value-5
- From: Jim Wilson <wilson at specifixinc dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 17 Feb 2004 02:02:18 -0800
- Subject: Re: ia64-hpux fix compat/struct-by-value-5
- References: <87smhaunnd.fsf@egil.codesourcery.com>
On Tue, 2004-02-17 at 00:16, Zack Weinberg wrote:
> ia64-hpux bootstrap in progress; comments?
I forgot to comment on the patch. I think the BYTES_BIG_ENDIAN checks
are unnecessary but harmless. If you always create the DImode parallel,
then we get the right result for both big and little endian. So the
checks can either be there or not be there, your choice. I think we get
slightly more efficient code for little-endian if the BYTES_BIG_ENDIAN
checks are there, so I don't mind them being there.
Isn't this going to break handling of regular SFmode arguments? I think
you only want to do this when hfa_mode is SFmode.
I think the second part of the patch is unnecessary. The special hfa
code at the top handles all cases except prototype && !named, so only
the first part of your patch is doing something useful. The second part
is unreachable code.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com