This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 100x -O0 Compile Time Regression {3.2,3.3} -> {3.4,3.5}
- From: law at redhat dot com
- To: Diego Novillo <dnovillo at redhat dot com>
- Cc: Daniel Berlin <dberlin at dberlin dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 16 Feb 2004 16:29:04 -0700
- Subject: Re: 100x -O0 Compile Time Regression {3.2,3.3} -> {3.4,3.5}
- Reply-to: law at redhat dot com
In message <1076671720.3252.33.camel@localhost.localdomain>, Diego Novillo writ
es:
>On Thu, 2004-02-12 at 23:35, Daniel Berlin wrote:
>
>[ moved to gcc-patches ]
>
>> Index: tree-cfg.c
>> ===================================================================
>> RCS file: /cvs/gcc/gcc/gcc/Attic/tree-cfg.c,v
>> retrieving revision 1.1.4.264
>> diff -u -3 -p -r1.1.4.264 tree-cfg.c
>> --- tree-cfg.c 4 Feb 2004 06:08:20 -0000 1.1.4.264
>> +++ tree-cfg.c 13 Feb 2004 04:34:59 -0000
>> @@ -3948,7 +3948,7 @@ split_critical_edges (void)
>> {
>> basic_block bb;
>> edge e;
>> -
>> + free_dominance_info (CDI_DOMINATORS);
>> FOR_ALL_BB (bb)
>> {
>> for (e = bb->succ; e ; e = e->succ_next)
>>
>This looks OK, provided it bootstraps, etc.
Zdenek's code is actually more appropriate as it efficiently keeps the
dominators up-to-date. I'd prefer to use it over just wiping out the
dominators.
jeff