This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH to represent column numbers using source_location

Per Bothner <per@bothner.com> writes:

> Kazu Hirata wrote:
>
>> Unfortunately, this patch breaks h8300-elf.  scan-decls.c:185 still
>> has a use of member "line" of cpp_token, which you have removed.
>> Would you mind taking a look at this?
>
>  From what I can tell of the code, the previous version was wrong,
> in that it was passing a source_location cookie to a function that
> expects an actual line number.
>
> I.e. I suspect this code hasn't worked correctly for years, or
> whenever token were changes to source line-map cookies.
>
> Could you try this patch?

scan-decls.c MUST NOT include cpphash.h.

zw
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]