This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: testsuite tweaks for powerpc64

From: "Zack Weinberg" <zack at codesourcery dot com>
To: Geoff Keating <geoffk at desire dot geoffk dot org>
Cc: amodra at bigpond dot net dot au, gcc-patches at gcc dot gnu dot org
Date: Mon, 09 Feb 2004 12:32:34 -0800
Subject: Re: testsuite tweaks for powerpc64
References: <20040209125657.GK12016@bubble.modra.org><200402092004.i19K4Fuf031248@desire.geoffk.org>

Geoff Keating <geoffk@desire.geoffk.org> writes:

> -# if !#cpu(powerpc) || !#machine(powerpc)
> +# if ((!defined(__powerpc64__) \
> +       && (!#cpu(powerpc) || !#machine(powerpc) \
> +	   || #cpu(powerpc64) || #machine(powerpc64))) \
> +      || (defined(__powerpc64__) \
> +          && (#cpu(powerpc) || #machine(powerpc) \
> +	      || !#cpu(powerpc64) || !#machine(powerpc64)))
>
> I really think this is too complicated.  How about
>
> #if defined(__powerpc64__)
>   some tests
> #else
>   original tests
> #endif

Furthermore, #foo(bar) is deprecated - in fact, the only reason I
haven't already ripped it out is that it's used in system headers
on a few platforms (eg. Solaris).  It should not be used in GCC's
own source code.

zw

References:
- testsuite tweaks for powerpc64
  - From: Alan Modra
- Re: testsuite tweaks for powerpc64
  - From: Geoff Keating

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]