This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix IA-64 bootstrap failure


> Jan Hubicka wrote:
> >	* alias.c (find_base_term, get_addr):  Do not dereference NULL
> >	pointer when all VALUE's locations has been invalidated.
> 
> This patch looks like the right idea.  If CSELIB_VAL_PTR is NULL, then 
> we have no alias info at all.
> 
> I believe you missed one place that needs to be fixed.  Just searching 
> for CSELIB_VAL_PTR, I see code in rtx_equal_for_memref_p
>     case VALUE:
>       return CSELIB_VAL_PTR (x) == CSELIB_VAL_PTR (y);

I am also re-running the bootstrap with this changed to x==y.
In the past I did a check that VALUEs are never copied, so this shall be
enough to ensure that the test shall not be too conservative modulo to
NULL values.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]