This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH] Fix PR c++/12007


John David Anglin wrote:

The enclosed patch fixes a problem with thunks that is probably specific
to the PA HP-UX port.


Cool!

This patch isn't quite right, in that you moved the DECL_ARGUMENTS copying to make_thunk. That's the function that declares the thunk, and DECL_ARGUMENTS shouldn't be created until the thunk is defined. Therefore, the copying should stay in use_thunk -- but it should happen right after the assignment to DECL_INITIAL.

Would you mind trying that change, and if it works out, checking it in to the mainline?

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]