This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lno-branch]: Please revert an unnecessary change
Hello,
> >no it is not. The problem is that if you do not have HAVE_BANSHEE
> >defined at the entry, you do not include tree-alias-ander.h, which
> >defines andersen_alias_ops.
> We can't (IIRC, i'm not near it ATM) because it pulls in banshee
> specific files.
>
> >Obviously the other possibility how to fix
> >the problem would be to always include the file, but it seems
> >unnecessary.
> >
>
> Then could you kindly remove the definition at the top of the file, and
> reifdef the whole thing rather than have
> #if HAVE_BANSHEE
> if (HAVE_BANSHEE &&)
> ...
done.
Zdenek
Index: ChangeLog.lno
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Attic/ChangeLog.lno,v
retrieving revision 1.1.2.33
diff -c -3 -p -r1.1.2.33 ChangeLog.lno
*** ChangeLog.lno 22 Jan 2004 01:10:44 -0000 1.1.2.33
--- ChangeLog.lno 22 Jan 2004 23:39:44 -0000
***************
*** 1,5 ****
--- 1,10 ----
2004-01-22 Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
+ * tree-alias-common.c (HAVE_BANSHEE): Do not define it.
+ (create_alias_vars): Do not test HAVE_BANSHEE value.
+
+ 2004-01-22 Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
+
* tree-ssa-loop-manip.c: New file.
* Makefile.in (tree-ssa-loop-manip.o): Add.
* basic-block.h (struct reorder_block_def): New field copy_number.
Index: tree-alias-common.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Attic/tree-alias-common.c,v
retrieving revision 1.1.2.45.2.2
diff -c -3 -p -r1.1.2.45.2.2 tree-alias-common.c
*** tree-alias-common.c 21 Jan 2004 09:24:58 -0000 1.1.2.45.2.2
--- tree-alias-common.c 22 Jan 2004 23:39:44 -0000
*************** Foundation, Inc., 59 Temple Place, Suite
*** 52,62 ****
#include "tree-pass.h"
#include "timevar.h"
- /* Reduce ifdefery later. */
- #ifndef HAVE_BANSHEE
- #define HAVE_BANSHEE 0
- #endif
-
/* This file contains the implementation of the common parts of the
tree points-to analysis infrastructure.
--- 52,57 ----
*************** static void
*** 975,982 ****
create_alias_vars (void)
{
basic_block bb;
! #if HAVE_BANSHEE
! if (HAVE_BANSHEE && flag_tree_points_to == PTA_ANDERSEN)
current_alias_ops = andersen_alias_ops;
else
#endif
--- 970,977 ----
create_alias_vars (void)
{
basic_block bb;
! #ifdef HAVE_BANSHEE
! if (flag_tree_points_to == PTA_ANDERSEN)
current_alias_ops = andersen_alias_ops;
else
#endif