This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [COMMITTED] Fix Re: <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0


I never heard about extern "C++" -- what is it, where is it documented?

Wow, it turns out, I don't know C++ at all.


+}//extern "C++"

This is wrong; please use a /* */ comment (yes I use std=gnu99 for all my
own code, but not everyone does) (and coding conventions require some
more spaces, too ;-) )

Never mind, this was in #ifdef __cplusplus protected code, as Andrew pointed
out to me privately. Which leaves only the spaces issue ;-)



Segher



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]