This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Virtual operands in tree-tailcall


Hello,

>  >	* tree-tailcall.c (eliminate_tail_call): Add phi nodes for the call
>  >	vdefs.
> You seem to have some gratutious changes included in this patch.  For
> example, why did you reverse the loops in the first hunk?  If there's
> a reason you did that, then you should indicate why you changed the
> iteration order of those loops.

since it is no longer true that every phi node corresponds to the
function's arguments, we must look for a phi for the argument, not
vice versa.

> Consider this pre-approved after you update the comment above and after
> you either revert the gratutious changes in loop order noted above or
> document the change to the loop ordering.

I am not really sure how to document this.  I may add a comment that
we are looking for the phi node for the argument, but it is obvious
from the code anyway.

Zdenek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]