This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Fix dominator bug
> On Wed, 2004-01-07 at 10:15, Jan Hubicka wrote:
>
> > Perhaps we can just add an sanity check here and insist on caller to do
> > whathever is needed to update dominance.
> >
> But in this particular case, it's easy to keep the dominance info
> up-to-date. The call to delete_from_dominance_info shouldn't be
> expensive. Which reminds me, have you seen any compile-time regressions
> due to this change, Steven?
Only dead code removal is transformation I can think of that would work
with this code without any other dominance tree manipulation.
But dead basic blocks can't be in the dminator tree anyway (we abort
while building the datastructure), so I would guess that almost any call
to delete_bb with dominance info claimed to be up to date is a bug.
Having abort here would be nice reminder that dominance info needs to be
either updated or fully invalidated.
Honza
>
>
> Diego.