This is the mail archive of the
mailing list for the GCC project.
Re: [tree-ssa] Cleanup and enhance dominator infrastructure
- From: law at redhat dot com
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: Diego Novillo <dnovillo at redhat dot com>, Daniel Berlin <dberlin at dberlin dot org>, Andrew Macleod <amacleod at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Tue, 06 Jan 2004 10:38:44 -0700
- Subject: Re: [tree-ssa] Cleanup and enhance dominator infrastructure
- Reply-to: law at redhat dot com
In message <20040106103113.GA27161@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak wri
>> If it's as slow as Zdenek claims, then we might as well just kill DEBUG_ET.
>the code was really useful to debug the thing. I would like to keep it
>there for the case it sometimes in the future turns out there is a bug
>somewhere in the code.
>> >> ! static int len;
>> >> ! static void *datas;
>> >> ! static int depths;
>> >Please #define these values and add guards in record_path_before_1.
>> Err, really? So we're just going to blindly allocate nearly a megabyte
>> of static data on a 32bit machine? That's lame, really lame. We're better
>> off getting that much data from the heap via malloc/free.
>These arrays are there only when DEBUG_ET is enabled.
Ah. OK. I don't care about them in that case :-)
I think Diego approved the changes for the branch and Roger approved
a port of them for the mainline (which helps keep divergence to a