Re: [v3 RFC] PATCH to memory asm ops in atomicity.h

[Andreas Tobler <toa at pop dot agri dot ch>]

Andreas Tobler wrote:

> Jason Merrill wrote:
>
> > Applied to trunk.
>
>
> Breaks darwin libstdc++.
> for details see: http://gcc.gnu.org/ml/gcc-regression/2003-12/txt00052.txt
>
> I reverted it and now darwin builds again.

PPC linux fails as well.

With this patchlet I (and my boxen) seem to be happy?

Correct?

diff -u -r1.7 atomicity.h
--- config/cpu/powerpc/atomicity.h      20 Dec 2003 03:08:41 -0000      1.7
+++ config/cpu/powerpc/atomicity.h      20 Dec 2003 14:08:05 -0000
@@ -47,7 +47,7 @@
        "/* Inline exchange & add */\n"
        "0:\t"
        "lwarx    %0,0,%3 \n\t"
-       "add%I3   %1,%0,%4 \n\t"
+       "add%I4   %1,%0,%4 \n\t"
        _STWCX "  %1,0,%3 \n\t"
        "bne-     0b \n\t"
        "/* End exchange & add */"
@@ -66,7 +66,7 @@
        "/* Inline atomic add */\n"
        "0:\t"
        "lwarx    %0,0,%2 \n\t"
-       "add%I2   %0,%0,%3 \n\t"
+       "add%I3   %0,%0,%3 \n\t"
        _STWCX "  %0,0,%2 \n\t"
        "bne-     0b \n\t"
        "/* End atomic add */"

Andreas