This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch]: Use `inform' instead of `warning' on mips-irix with -g -mabi=32
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sat, 13 Dec 2003 21:58:18 -0500 (EST)
- Subject: [patch]: Use `inform' instead of `warning' on mips-irix with -g -mabi=32
As mentioned here:
http://gcc.gnu.org/ml/gcc-patches/2003-12/msg01092.html
there are some cases where a diagnostic shouldn't cause a -Werror
failure. IMHO this warning is one of them. Changing this diagnostic
to a `note' allows us to remove the -Wno-error from target files in a
bootstrap.
Bootstrapped on mips-sgi-irix6.5 with -Werror enabled on target files
to ensure we really don't need the -Wno-error.
Ok for mainline?
Thanks,
--Kaveh
2003-12-13 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* config/mips/mips.c (override_options): Use `inform' instead
of `warning' for -g -mabi=32 and native assembler.
* config/mips/t-iris6 (CRTSTUFF_T_CFLAGS, TARGET_LIBGCC2_CFLAGS):
Don't pass -Wno-error.
diff -rup orig/egcc-CVS20031212/gcc/config/mips/mips.c egcc-CVS20031212/gcc/config/mips/mips.c
--- orig/egcc-CVS20031212/gcc/config/mips/mips.c 2003-12-11 20:01:45.000000000 -0500
+++ egcc-CVS20031212/gcc/config/mips/mips.c 2003-12-12 23:19:05.589321130 -0500
@@ -4662,10 +4662,10 @@ override_options (void)
/* Adapt wording to IRIX version: IRIX 5 only had a single ABI,
so -mabi=32 isn't usually specified. */
if (TARGET_IRIX5)
- warning ("-g is only supported using GNU as,");
+ inform ("-g is only supported using GNU as,");
else
- warning ("-g is only supported using GNU as with -mabi=32,");
- warning ("-g option disabled");
+ inform ("-g is only supported using GNU as with -mabi=32,");
+ inform ("-g option disabled");
write_symbols = NO_DEBUG;
}
}
diff -rup orig/egcc-CVS20031212/gcc/config/mips/t-iris6 egcc-CVS20031212/gcc/config/mips/t-iris6
--- orig/egcc-CVS20031212/gcc/config/mips/t-iris6 2003-11-21 20:00:59.000000000 -0500
+++ egcc-CVS20031212/gcc/config/mips/t-iris6 2003-12-12 23:15:20.686666827 -0500
@@ -12,11 +12,7 @@ INSTALL_LIBGCC = install-multilib
# end labels to the .ctors and .dtors section when we link using gcc.
EXTRA_MULTILIB_PARTS=crtbegin.o crtend.o
-# When the native assembler is in use, -g is not supported with the O32 ABI
-# and we get a warning for every -mabi=32 compilation. Work around this
-# by adding -Wno-error.
-CRTSTUFF_T_CFLAGS=-g1 -Wno-error
-TARGET_LIBGCC2_CFLAGS = -Wno-error
+CRTSTUFF_T_CFLAGS=-g1
LIB2FUNCS_EXTRA = $(srcdir)/config/mips/_tilib.c