This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] tree_ssa_useless_type_conversion_p tweek
- From: law at redhat dot com
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 02 Dec 2003 13:27:48 -0700
- Subject: Re: [tree-ssa] tree_ssa_useless_type_conversion_p tweek
- Reply-to: law at redhat dot com
In message <20031127231510.GJ1906@kam.mff.cuni.cz>, Jan Hubicka writes:
>Hi,
>for the type checking work I need to be able to verify that given conversion
>is
>useless when I don't have the NOP anymore. Does the attached change look fin
>e?
>I am not at all sure about nice name of the new function.
>
>I've also included one change in the functionality WRT complex types. I now
>allow
>complex types to match when their subtypes match. This is actually needed
>because convert call does not introduce any NOP when main variants of subtype
> match.
>
>Bootstrapped/regtested i686-pc-gnu-linux and x86_64-linux.
>Honza
>
>2003-11-28 Jan Hubicka <jh@suse.cz>
> * tree-flow.h (tree_ssa_useless_type_conversion_1): Declare.
> * tree-flow.c (tree_ssa_useless_type_conversion_1): Break out from
> from...; allow complex types whose subtypes match.
> (tree_ssa_useless_type_conversion): ... here.
This is fine. Though I think that you need to update the comment
before tree_ssa_useless_type_conversion_1. It references EXPR when
it should reference OUTER_TYPE and INNER_TYPE.
jeff