This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] for Review: Fix for PR java/12548
- From: Jeff Sturm <jsturm at one-point dot com>
- To: Mohan Embar <gnustuff at thisiscool dot com>
- Cc: gcc-patches at gcc dot gnu dot org, GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Sun, 23 Nov 2003 13:10:29 -0500 (EST)
- Subject: Re: [PATCH] for Review: Fix for PR java/12548
On Sun, 23 Nov 2003, Mohan Embar wrote:
> This patch attempts to fix this:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12548
Great, thanks!
> This isn't my area of expertise, so I might be
> diagnosing the problem incorrectly....
Your analysis looks mostly correct to me, except that I think this is
breaking on any targets that don't use .jcr sections. Weak symbols
aren't directly involved here.
> I ran some informal tests on Linux
> and Win32 with this, successfully compiling and using
> jarfiles, but don't know how to run Jacks or whatever else
> might be needed to officially certify this.
Jacks has no resource tests, so I'd be very surprised if it were affected
by this patch.
> - init_name = get_file_function_name ('I');
> + init_name =
> + get_identifier (
> + concat (IDENTIFIER_POINTER (get_file_function_name ('I')),
> + "_resource", NULL));
> init_type = build_function_type (void_type_node, end_params_node);
I think you need to free the result of concat.
You'll need approval from Andrew Haley for this.
Jeff