This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] tree_verify_flow_info tweeks II


> On Thu, 2003-11-06 at 11:20, Jan Hubicka wrote:
> 
> > +       /* Verify that body of basic block is free of control flow.  */
> > +       for (; !bsi_end_p (bsi); bsi_next (&bsi))
> > + 	{
> > + 	  tree stmt = bsi_stmt (bsi);
> > + 
> > + 	  if (last)
> >
> Rename 'last' to something more descriptive like 'found_ctrl_stmt_p'. 
> Initialize it right before the loop.
> Leave some space around major blocks of code.
> 
> > + 	    {
> > + 	      error ("Control flow in the middle of basic block %d\n", bb->index);
> > + 	      err = 1;
> > + 	    }
> > + 	  if (stmt_ends_bb_p (stmt))
> > + 	    last = true;
> > + 	  if (TREE_CODE (stmt) == LABEL_EXPR)
> > + 	    {
> > + 	      error ("Label in the middle of basic block %d\n", bb->index);
> > + 	      err = 1;
> >
> Print out the name of the label the message is referring to.  Similarly
> in other places where we emit errors about labels.
> 
> > + 					   | EDGE_TRUE_VALUE | EDGE_FALSE_VALUE)))
> > + 		  {
> > + 		    error ("Wrong outgoing edge flags at end of bb %d\n", bb->index);
> > + 		    err = 1;
> > + 		  }
> > + 	      }
> > + 	    /* Check we do have all of them.  */
>               /* Check that we have all of them.  */
> 
> 
> 
> OK with those changes.  Have the dependencies for this patch been
Thanks.
> committed yet?  If not, point me to it?
I tought that the edge splitting problems still remain, but bootstrap
went to stage 3 so apparently the problem is gone.  THis is excelent
news as I can send the RTL expansion patch tomorrow.

I will commit the updated patch in case it fully bootstraps.

Honza
> 
> 
> Thanks.  Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]