Re: 3.4 PATCH: Remove duplication in ada/Makefile.in

[Rainer Orth <ro at TechFak dot Uni-Bielefeld dot DE>]

Richard Kenner writes:

> The problem with the ADAC was the risk that CC and ADAC would be
> incompatible.  We got about as many of those reports as those where
> no single compiler would compile the entire thing.  So it would be a
> shame to reintroduce it.

I tend to agree: it shouldn't be too hard for someone doing an initial port
of GNAT to live without ADAC, and everything else (like my case) seems to
be an extremely special situation.

>      # use cross-gcc
>      gnat-cross: force
>     -	$(MAKE) -C ada $(FLAGS_TO_PASS) $(ADA_FLAGS_TO_PASS) gnat-cross
>     +	make $(GNAT1_ADA_OBJS) CC="gcc -B../stage1/" CFLAGS="-S -gnatp" \
>     +		$(FLAGS_TO_PASS) $(ADA_FLAGS_TO_PASS) HOST_CFLAGS= HOST_CC=cc
>  
>       seems bogus: HOST_CC should be whatever $(CC) was found during configure,
>       not hardcoding cc here.
> 
> I agree with your point about HOST_CC, but everything else is correct.

Sorry for the imprecise wording: I was only complaining about HOST_CC=cc,
nothing else.

>     -ada/adafinal.o    : ada/adafinal.c $(CONFIG_H) $(SYSTEM_H) ada/raise.h 
>     +ada/final.o    : ada/final.c $(CONFIG_H) $(SYSTEM_H) ada/raise.h 
> 
>       looses the fix for PR ada/8344.
> 
> Intentionally.  I do not see any reason to make that change.

I hadn't checked the PR in detail, but indeed the message mentioned there
doesn't contain any details about the failure.

>     Wed Oct 29 22:20:32 2003  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>
>     
> 	* Makefile.in: Remove many duplicate variables.
> 
> But this is OK.

Thanks, checked in.

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University