This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v850 patch?] num_sign_bit_copies1: sign_extending consts

On Tue, Nov 04, 2003 at 09:48:11AM -0500, DJ Delorie wrote:
> 	* config/v850/v850.md (mulhisi3): Expand the const_int case
> 	separately to avoid trying to sign extend the const.

Almost ok.

>   ;; ??? Sign extending constants isn't valid.  Fix?

Comment now addressed.  ;-)

> ! 	  (match_operand:SI 2 "const_int_operand" "J,K")))]

I think you want a more specific predicate here, lest combine
try to substitute a larger constant and leave reload no way
to handle it at all.

Hmm... I don't actually see anything wrong with using 
mismatched modes here.  You should be able to just use :HI,
which will dtrt in const_int_operand.


r~
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]