Re: Question on -Werror usage in Makefiles...

[Andreas Jaeger <aj at suse dot de>]

Andreas Jaeger <aj@suse.de> writes:

> Andreas Jaeger <aj@suse.de> writes:
>
>> make proto now throws errors.  Is the appended patch the right thing
>> to do fix the warnings when building SYSCALLS.o ?
>
> Digging deeper into this, I see that the following should do the trick
> - but doesn't:
> SYSCALLS.c.X-warn = -Wno-error
>
> GCC_CFLAGS should include WARN_CFLAGS for this to work.
>
> I'm testing now the appended patch.  Ok to commit this version if it
> passes bootstrap on x86_64-linux-gnu?

My change adds STRICT_WARN for the files which then enables additional
warnings.  I'm not sure whether we want this :-(

So, I see the following solutions:
- Reverting Kaveh's patch that I committed
- Adding some hack so that e.g.  SYSCALLS.c.X-warn = -Wno-error works
- Using my patch below and adding -Wno-error to GCC_CFLAGS since we
  get too many warnings otherwise and this helps to cut them down.
- Using my patch below and white-listening the files that make
  problems
- Using my patch below and fixing everything.

I'll work on the fixing the obvious warnings now but I'm sure that I
cannot fix everything directly...

Andreas

> Andreas
>
> 2003-11-01  Andreas Jaeger  <aj@suse.de>
>
> 	* Makefile.in (GCC_CFLAGS): Use WARN_CFLAGS instead of WERROR.
> 	(SYSCALLS.c.X-warn): Suppress warnings.
>
> ============================================================
> Index: gcc/Makefile.in
> --- gcc/Makefile.in	1 Nov 2003 16:58:43 -0000	1.1188
> +++ gcc/Makefile.in	1 Nov 2003 17:57:08 -0000
> @@ -187,6 +187,8 @@ gengtype-yacc.o-warn = -Wno-error
>  c-parse.o-warn = -Wno-error
>  # flex output may yield harmless "no previous prototype" warnings
>  gengtype-lex.o-warn = -Wno-error
> +# SYSCALLS.c misses prototypes.
> +SYSCALLS.c.X-warn = -Wno-error
>  
>  # All warnings have to be shut off in stage1 if the compiler used then
>  # isn't gcc; configure determines that.  WARN_CFLAGS will be either
> @@ -287,7 +289,7 @@ GCC_FOR_TARGET = $(STAGE_CC_WRAPPER) ./x
>  # This is used instead of ALL_CFLAGS when compiling with GCC_FOR_TARGET.
>  # It omits XCFLAGS, and specifies -B./.
>  # It also specifies -isystem ./include to find, e.g., stddef.h.
> -GCC_CFLAGS=$(INTERNAL_CFLAGS) $(X_CFLAGS) $(T_CFLAGS) $(LOOSE_WARN) @WERROR@ -isystem ./include $(TCFLAGS)
> +GCC_CFLAGS=$(INTERNAL_CFLAGS) $(X_CFLAGS) $(T_CFLAGS) $(WARN_CFLAGS) -isystem ./include $(TCFLAGS)
>  
>  # ---------------------------------------------------
>  # Programs which produce files for the target machine

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature