This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to build1 for c/12553
- From: Olivier Hainque <hainque at act-europe dot fr>
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, jason at redhat dot com, hainque at act-europe dot fr
- Date: Tue, 21 Oct 2003 14:32:37 +0200
- Subject: Re: PATCH to build1 for c/12553
- References: <10310211227.AA01348@vlsi1.ultra.nyu.edu>
Richard Kenner wrote:
> + int i = first_rtl_op (TREE_CODE (node));
> + for (; i >= 0; --i)
>
> Isn't there a problem if "node" has only tree operands here, because
> "i" starts as the number of operands in that case ?
>
> Actually, there's a problem in *all* cases: this is an off-by-one error.
> It should be first_rtl_op (...) - 1. Making that change is pre-approved.
Ah, indeed. I overlooked the underlying intent. Thanks.