This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [m68k] remove obsolete comments from m68k.c

From: Gunther Nikl <gni at gecko dot de>
To: Bernardo Innocenti <bernie at develer dot com>
Cc: Andreas Schwab <schwab at suse dot de>, gcc-patches at gcc dot gnu dot org
Date: Mon, 20 Oct 2003 11:28:59 +0200
Subject: Re: [m68k] remove obsolete comments from m68k.c
References: <20031017141924.GA18224@lorien.int.gecko.de> <je4qy8kkac.fsf@sykes.suse.de> <3F9037E4.2050704@develer.com>

On Fri, Oct 17, 2003 at 08:41:40PM +0200, Bernardo Innocenti wrote:
> Andreas Schwab wrote:
> 
> >>In a previous patch some comments about asm_fprintf() not handling '%' got
> >>removed. The attached patch removes some more occurences.
> >
> >Why?  The comment is actually talking about %. and is still correct.
> >Otherwise most of these #ifdef MOTOROLA could be removed.
> 
> The comments are right, but IMHO it's pointless and it makes those
> #ifdef/#else/#endif blocks even harder to parse with the eye.
> 
> If we _really_ want to advertise this fact, we could use a single, more
> descriptive comment somewhere near the top of m68k.c.

  Fine with me.

  Gunther

Follow-Ups:
- Re: [m68k] remove obsolete comments from m68k.c
  - From: Bernardo Innocenti

References:
- [m68k] remove obsolete comments from m68k.c
  - From: Gunther Nikl
- Re: [m68k] remove obsolete comments from m68k.c
  - From: Andreas Schwab
- Re: [m68k] remove obsolete comments from m68k.c
  - From: Bernardo Innocenti

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]